Skip to content

Clean up backend code #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2025
Merged

Clean up backend code #2259

merged 2 commits into from
Jan 14, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 14, 2025 •
edited
Loading

The PR proposed to remove unused code from the backend.
Specially it's about removing local constant striped which produces compilation warnings.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 70.943% (+0.03%) from 70.914%
when pulling 72f2999 on remove-unused-vars
into 44bb068 on master.

vlad-perevezentsev
vlad-perevezentsev approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @antonwolfy !

@antonwolfy antonwolfy merged commit ce3ef5e into master Jan 14, 2025
57 of 58 checks passed
@antonwolfy antonwolfy deleted the remove-unused-vars branch January 14, 2025 13:20
github-actions bot added a commit that referenced this pull request Jan 14, 2025
@github-actions
Clean up backend code (#2259)
1ffc37b 
The PR proposed to remove unused code from the backend.
Specially it's about removing local constant `striped` which produces
compilation warnings. ce3ef5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vtavana vtavana Awaiting requested review from vtavana

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @vlad-perevezentsev